-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new base-root.htm template #38
Changes from all commits
19fe689
627bc5b
23a8352
04054b1
ccac31f
3709437
1b34320
10836fb
2a0fdc6
3535b1c
82f08ce
a9f774d
d11de7d
cd108bd
ee3e24a
6640f22
084765c
7c47ae1
eafebcf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,14 @@ | ||
from django.apps import AppConfig | ||
from django.conf import settings | ||
|
||
from arches.settings_utils import generate_frontend_configuration | ||
|
||
class Arches_LingoConfig(AppConfig): | ||
|
||
class ArchesLingoConfig(AppConfig): | ||
name = "arches_lingo" | ||
verbose_name = "Arches Lingo" | ||
is_arches_application = True | ||
|
||
def ready(self): | ||
if settings.APP_NAME.lower() == self.name: | ||
generate_frontend_configuration() |
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import LingoApp from '@/arches_lingo/App.vue'; | ||
import createVueApplication from 'arches/arches/app/media/js/utils/create-vue-application'; | ||
|
||
createVueApplication(LingoApp).then(vueApp => { | ||
vueApp.mount('#lingo-mounting-point'); | ||
}); |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<script setup> | ||
import Foo from "@/arches_lingo/components/FooComponent.vue"; | ||
</script> | ||
|
||
<template> | ||
<Foo /> | ||
</template> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,4 @@ | ||
// import declarations from other projects or Arches core | ||
import("../../node_modules/arches/arches/app/src/declarations.d.ts"); | ||
|
||
// declare untyped modules that have been added to your project in `package.json` | ||
// Module homepage on npmjs.com uses logos "TS" or "DT" to indicate if typed | ||
declare module "arches"; | ||
|
||
// declare filetypes used in `./src/` folder | ||
declare module "*.ts"; | ||
declare module "*.vue"; | ||
import("@/arches/declarations.d.ts"); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{% extends "base-root.htm" %} | ||
|
||
{% block title %} | ||
|
||
{% endblock title %} | ||
|
||
{% block body %} | ||
<div id="lingo-mounting-point"></div> | ||
{% endblock body %} |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want this above arches since it's an arches application?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't matter, as long as
arches.app
is at the bottomThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was only true for templates, not css/img discovery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oooO maybe not...arches.app
only ever has templates, notmedia/build/...
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just tested with an image and the results are as you'd expect ( project -> apps -> core ), but happy to chat if you'd like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'm with you now. I forgot how specialized we made
ArchesApplicationsStaticFilesFinder
, which even if there's an"arches"
in the middle of INSTALLED_APPS, there won't be anything underarches/media
, so this should be A-OK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobtylerwalls @chrabyrd back from the future -
arches_references
has to go abovearches
because there are commands inarches_references/packages.py
that need to be included in the packages options. I'll fix as part of #53