Adds scheme names/labels section #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to merge into main before/at the same time as JC's form editor ticket. |
chrabyrd
requested changes
Dec 19, 2024
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/scheme/report/SchemeSection.vue
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/generic/LabelViewer.vue
Outdated
Show resolved
Hide resolved
chrabyrd
requested changes
Dec 20, 2024
| /> | ||
| <Column | ||
| field="appellative_status_ascribed_name_content" | ||
| header="Label" |
| @@ -26,7 +26,9 @@ function onUpdate(val: string[]) { | |||
| <div v-if="mode === EDIT"> | |||
| <ResourceInstanceRelationshipsEditor | |||
| :options="options" | |||
| :val="value?.map((x) => x.resourceId) ?? []" | |||
| :val=" | |||
| value?.map((referenceValue) => referenceValue.resourceId) ?? [] | |||
|
|
||
| async function deleteSectionValue(tileId: string) { | ||
| const result = await deleteSchemeLabelTile(tileId); | ||
| if (result) { |
There was a problem hiding this comment.
Yeah, there should be error handling for sure. IMO wrap this in a try/catch that will raise a Toast error. I'd say same with getSectionValue and any other API.
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Show resolved
Hide resolved
|
There is a second, related item to genericize the label viewer. I separated it from this PR to get commentary on patterns therein. See #161 - set to merge into this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scheme names/labels section