Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Concept and Scheme models #127

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

johnatawnclementawn
Copy link
Member

@johnatawnclementawn johnatawnclementawn commented Nov 15, 2024

Resolves #123

This will break the test data - the RDM -> Lingo migration will need to be re-run, and likely updated based on new model configurations.

Copy link
Member

@robgaston robgaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@johnatawnclementawn
Copy link
Member Author

  1. load AFS thesaurus
  2. start celery (I use python -m celery -A arches_lingo worker -l info)
  3. Run RDM to Lingo ETL module for AAT Entries http://localhost:8000/plugins/bulk-data-manager
  4. Verify number of part_of_scheme tiles created matches the number of concept resources created

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested. Few things noticed along the way that can be follow-ups:

  • make etl_modules an explicit package, so that it's measured by coverage
  • use CommandError
  • catch CommandError and surface the error message in the GUI, but may want to check with @chiatt

@johnatawnclementawn johnatawnclementawn force-pushed the jmc/123_remigrate_lingo_models branch from 1c5688e to 47151b4 Compare November 20, 2024 14:55
@johnatawnclementawn
Copy link
Member Author

johnatawnclementawn commented Nov 20, 2024

@robgaston coverage was previously passing because Lingo ETL Modules was not a package. Given the blocking nature of these model changes for other work in flight, I created a follow-up issue #131. Would you like to see that addressed in this PR or okay to do the follow up?

@robgaston
Copy link
Member

@johnatawnclementawn it's fine to address the coverage in the follow up ticket

@johnatawnclementawn johnatawnclementawn merged commit 1ac7271 into main Nov 20, 2024
4 of 5 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jmc/123_remigrate_lingo_models branch November 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-migrate concept->reference nodes with default values
3 participants