Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bestsource: Bump to R4 #125

Closed
wants to merge 1 commit into from
Closed

bestsource: Bump to R4 #125

wants to merge 1 commit into from

Conversation

0tkl
Copy link

@0tkl 0tkl commented Apr 18, 2024

Since 900876c there’s quite a lot progress in the upstream, especially the meson.build got overhauled. So removing avs/vs plugin by patch are no longer needed since vapoursynth/bestsource@477a7f5; and the link_static option become prefer_static since vapoursynth/bestsource@d59b689.

I'm a total amateur to all the decoding internals so the only thing I check is API changes. AFAIK the only difference after 900876c is a new cachemode parameter introduced in vapoursynth/bestsource@ae44622.

@0tkl 0tkl changed the base branch from feature to bestsource April 18, 2024 00:29
@arch1t3cht
Copy link
Owner

Thanks for the PR, but soon after the commit bestsource is currently pinned to, the headers started to use std::filesystem::path, which needs C++17 (while arch1t3cht/Aegisub is still C++11). So this can't be merged right now (and IMO the differences from the current commit to R2 aren't big enough to warrant hacks like making a small C++17 wrapper library to work around this).

TypesettingTools/Aegisub has already switched to C++20, and I plan to eventually figure out how to rebase my changes on top of that - when that's done this PR can be merged.

@0tkl 0tkl changed the title bestsource: Bump to R2 bestsource: Bump to R4 May 8, 2024
@0tkl
Copy link
Author

0tkl commented May 31, 2024

Merged in 0a01ecf

@0tkl 0tkl closed this May 31, 2024
@0tkl 0tkl deleted the arkt_bs branch May 31, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants