fix(mega): use config file name for final merge #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model name of intermediate models again after regression from base_model fix
|
The forcing of noname isn't needed for everyone so perhaps that should be an opt-in cli parameter. Using the name of the file when its not present will be useful for everyone. |
|
I went ahead and snuck in a flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from Henky, updates mergekit-mega to require one of the merges to omit the name key, that will then use the name of the config file for the name.
Also fixes a bug I introduced when allowing the base model to be an intermediate model where it wouldn't update the merge models to the correct path
And removes some unnecessary print statements that I forgot to remove