add whisper model #458
Open
add whisper model #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: The layer template for the decoder is marked as optional since, for distilled or turbo models, the number of decoder layers is less than the number of encoder layers, and we have no way to separate them. Signed-off-by: sagewe <[email protected]>
Signed-off-by: sagewe <[email protected]>
cg123
reviewed
Nov 29, 2024
| revision=donor_model.model.revision, | ||
| trust_remote_code=trust_remote_code, | ||
| ) | ||
| _set_chat_template(feature_extractor, merge_config) |
There was a problem hiding this comment.
I think this is incorrect - feature extractors don't have a chat template do they? Not that it seems to be breaking anything but it's extra work anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for whisper model