Fix missing constituents update after removing ghost cells #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avant de mettre à jour les mailles fantômes. Sans cela, l'appel à 'IMeshModifier::updateGhostLayerFromParent()' est fait alors que les matériaux ne sont pas à jour ce qui peut provoquer des plantages.
grospelliergilles
added
bug
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
==========================================
+ Coverage 70.21% 70.25% +0.03%
==========================================
Files 2261 2261
Lines 162507 162522 +15
Branches 18708 18716 +8
==========================================
+ Hits 114100 114172 +72
+ Misses 41628 41572 -56
+ Partials 6779 6778 -1 ☔ View full report in Codecov by Sentry. |
grospelliergilles
deleted the
dev/gg-fix-material-update-after-removing-ghost-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.