Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'MemoryUtils::getAcceleratorHostMemoryAllocator()' #1817

Merged

Conversation

grospelliergilles
Copy link
Member

We should use MemoryUtils::getDefaultDataAllocator() instead.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Dec 3, 2024
@grospelliergilles grospelliergilles self-assigned this Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.21%. Comparing base (07caef1) to head (8cb0739).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/utils/MemoryResourceMng.cc 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   70.25%   70.21%   -0.04%     
==========================================
  Files        2261     2261              
  Lines      162517   162507      -10     
  Branches    18714    18708       -6     
==========================================
- Hits       114172   114100      -72     
- Misses      41566    41628      +62     
  Partials     6779     6779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 2cacd83 into main Dec 3, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant