Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some computation of index list of an environment if it is not impacted by a modification #1682

Merged

Conversation

grospelliergilles
Copy link
Member

No description provided.

…ieu que si ce dernier est impacté par une modification.

Si le milieu n'est pas modifié la liste sera vide. Ce test permet d'éviter
un calcul inutile.
@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup arcane:materials Management of Constituents (Material/Environment) labels Oct 12, 2024
@grospelliergilles grospelliergilles self-assigned this Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (ab21b6b) to head (01fb34c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/arcane/materials/ConstituentConnectivityList.cc 92.85% 0 Missing and 1 partial ⚠️
...e/src/arcane/materials/MeshMaterialModifierImpl.cc 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
- Coverage   70.10%   70.09%   -0.01%     
==========================================
  Files        2249     2249              
  Lines      160458   160469      +11     
  Branches    18521    18526       +5     
==========================================
- Hits       112493   112485       -8     
- Misses      41249    41267      +18     
- Partials     6716     6717       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 293c9bb into main Oct 12, 2024
29 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-use-modified-envs-to-filter-some-operations branch October 14, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:materials Management of Constituents (Material/Environment) arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant