Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computed constituents impacted during material modification and exclude them from some treatments #1681

Merged

Conversation

grospelliergilles
Copy link
Member

This will prevent some calls to kernel which filters modified cells.

…ur accélérateur avec la taille du tableau sur l'hôte.
…ilise pour détecter si un matériau doit être mis à jour.
@grospelliergilles grospelliergilles added arcane Arcane Component arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) labels Oct 11, 2024
@grospelliergilles grospelliergilles self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.11%. Comparing base (96d6fe2) to head (67f8470).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rc/arcane/materials/ConstituentConnectivityList.cc 88.23% 1 Missing and 1 partial ⚠️
arcane/src/arcane/utils/DualUniqueArray.h 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1681   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files        2249     2249           
  Lines      160423   160460   +37     
  Branches    18518    18523    +5     
=======================================
+ Hits       112474   112503   +29     
- Misses      41237    41246    +9     
+ Partials     6712     6711    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit ab21b6b into main Oct 11, 2024
29 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-mark-modified-constituents-during-modification branch October 14, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane:accelerator Arcane Accelerator API/Runtime arcane:materials Management of Constituents (Material/Environment) arcane Arcane Component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant