Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always do an error if partitionner specified by the user is not available. #1635

Merged

Conversation

grospelliergilles
Copy link
Member

Before that PR, only a warning was displayed.

…é par l'utilisateur n'existe pas.

Auparavant on indiquait juste un avertissement.
@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Sep 23, 2024
@grospelliergilles grospelliergilles self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.50%. Comparing base (eacfaf3) to head (7c199a4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
arcane/src/arcane/impl/SubDomain.cc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
- Coverage   69.50%   69.50%   -0.01%     
==========================================
  Files        2240     2240              
  Lines      159860   159857       -3     
  Branches    18418    18417       -1     
==========================================
- Hits       111110   111103       -7     
  Misses      42126    42126              
- Partials     6624     6628       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit d280518 into main Sep 23, 2024
29 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-do-error-if-user-partitioner-not-found branch September 25, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant