Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate methods 'lookupAdd', 'lookupValue' and 'buckets' of 'ItemInternalMap' #1624

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

grospelliergilles
Copy link
Member

No description provided.

@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Sep 11, 2024
@grospelliergilles grospelliergilles self-assigned this Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 75.43860% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.52%. Comparing base (e9a7da4) to head (389a555).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
arcane/src/arcane/mesh/OneMeshItemAdder.cc 70.83% 7 Missing ⚠️
arcane/src/arcane/mesh/DynamicMeshKindInfos.cc 25.00% 3 Missing ⚠️
arcane/src/arcane/mesh/ItemInternalMap.h 66.66% 2 Missing ⚠️
arcane/src/arcane/mesh/DoFFamily.cc 91.66% 1 Missing ⚠️
arcane/src/arcane/mesh/PolyhedralMesh.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1624   +/-   ##
=======================================
  Coverage   69.52%   69.52%           
=======================================
  Files        2242     2242           
  Lines      159710   159719    +9     
  Branches    18410    18411    +1     
=======================================
+ Hits       111036   111046   +10     
+ Misses      42054    42052    -2     
- Partials     6620     6621    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grospelliergilles grospelliergilles merged commit 63218e0 into main Sep 11, 2024
29 checks passed
@grospelliergilles grospelliergilles deleted the dev/gg-continue-cleanup-iteminternalmap branch September 25, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arcane Arcane Component refactoring Code refactoring and cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant