Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClinicaDL dictionary #688

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ClinicaDL dictionary #688

merged 1 commit into from
Dec 18, 2024

Conversation

camillebrianceau
Copy link
Collaborator

@camillebrianceau camillebrianceau commented Dec 17, 2024 •
edited
Loading

An idea for a new module Dictionary with all the str that we use repetitively in the code.
I added an example for the Transforms module.

@camillebrianceau camillebrianceau marked this pull request as ready for review December 18, 2024 11:03
thibaultdvx
thibaultdvx approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@thibaultdvx thibaultdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, LGTM!

@camillebrianceau camillebrianceau merged commit 4d40ba6 into aramis-lab:clinicadl_v2 Dec 18, 2024
10 checks passed
@camillebrianceau camillebrianceau deleted the cb_dictionary branch December 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultdvx thibaultdvx thibaultdvx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camillebrianceau @thibaultdvx