-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset module for v2 #685
Dataset module for v2 #685
Conversation
You meant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @camillebrianceau!!
from .reader import Reader | ||
|
||
|
||
class CapsMultiReader: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, why did you feel the need to create this reader? Is it temporary?
Because I thought that we would handle multi-cohort with multiple CapsDataset
, concatenated with ConcatDataset
. And it seems to me that each CapsDataset
could have its own CapsReader
.
Tell me if I'm not clear enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I didn't explain but it was just a first draft. Then we put the CapsReader
in the CapsDataset
so it is not useful anymore but since we’re not entirely sure about our change, I prefer not to delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, LGTM!
In this PR, I refactored the
dataset
module with the following changes:API/dataset_test.py
in the PR to provide an example of how the dataset is used.CapsDataset
for all extraction modes.Future implementations in ClinicaDL will introduce:
ConcatDataset
PairedDataset
UnPairedDataset
These will inherit from
CapsDataset
.pydantic
). This object describes:The extraction process has been moved to the
Transforms
module. Each extraction type (ROI
,Image
,Slice
, andPatch
) is now represented as an object and behaves like a transform.I added unit tests. However, tests for
Transforms
andPreprocessing
are not included, as these components are expected to change in the coming weeks.