Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add API #670

Closed
wants to merge 16 commits into from
Closed

add API #670

wants to merge 16 commits into from

Conversation

camillebrianceau
Copy link
Collaborator

Add a file API_test_v2.py as an example of how the API will look like at the end of the refactoring

@camillebrianceau camillebrianceau marked this pull request as ready for review October 11, 2024 12:44
@pep8speaks
Copy link

Hello @camillebrianceau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:1: E302 expected 2 blank lines, found 1
Line 13:1: E302 expected 2 blank lines, found 1
Line 16:1: E302 expected 2 blank lines, found 1
Line 19:1: E302 expected 2 blank lines, found 1
Line 22:1: E302 expected 2 blank lines, found 1
Line 25:1: E302 expected 2 blank lines, found 1
Line 28:1: E302 expected 2 blank lines, found 1
Line 31:1: E302 expected 2 blank lines, found 1
Line 34:1: E302 expected 2 blank lines, found 1
Line 37:1: E302 expected 2 blank lines, found 1
Line 41:1: E305 expected 2 blank lines after class or function definition, found 1
Line 42:49: E251 unexpected spaces around keyword / parameter equals
Line 42:51: E251 unexpected spaces around keyword / parameter equals
Line 44:40: E261 at least two spaces before inline comment
Line 45:50: E251 unexpected spaces around keyword / parameter equals
Line 48:100: E251 unexpected spaces around keyword / parameter equals
Line 48:102: E251 unexpected spaces around keyword / parameter equals
Line 49:44: E251 unexpected spaces around keyword / parameter equals
Line 49:46: E251 unexpected spaces around keyword / parameter equals
Line 49:90: E251 unexpected spaces around keyword / parameter equals
Line 49:160: E261 at least two spaces before inline comment
Line 49:176: W291 trailing whitespace
Line 52:31: E225 missing whitespace around operator
Line 52:99: E251 unexpected spaces around keyword / parameter equals
Line 52:101: E251 unexpected spaces around keyword / parameter equals
Line 53:44: E251 unexpected spaces around keyword / parameter equals
Line 53:46: E251 unexpected spaces around keyword / parameter equals
Line 53:78: E251 unexpected spaces around keyword / parameter equals
Line 53:136: W291 trailing whitespace
Line 56:44: E261 at least two spaces before inline comment
Line 56:45: E262 inline comment should start with '# '
Line 58:31: E221 multiple spaces before operator
Line 58:59: E201 whitespace after '('
Line 58:70: E251 unexpected spaces around keyword / parameter equals
Line 58:72: E251 unexpected spaces around keyword / parameter equals
Line 58:100: E251 unexpected spaces around keyword / parameter equals
Line 58:102: E251 unexpected spaces around keyword / parameter equals
Line 58:131: E251 unexpected spaces around keyword / parameter equals
Line 58:133: E251 unexpected spaces around keyword / parameter equals
Line 58:169: E251 unexpected spaces around keyword / parameter equals
Line 58:171: E251 unexpected spaces around keyword / parameter equals
Line 59:73: E251 unexpected spaces around keyword / parameter equals
Line 59:75: E251 unexpected spaces around keyword / parameter equals
Line 59:104: E251 unexpected spaces around keyword / parameter equals
Line 59:133: E251 unexpected spaces around keyword / parameter equals
Line 59:135: E251 unexpected spaces around keyword / parameter equals
Line 59:171: E251 unexpected spaces around keyword / parameter equals
Line 59:173: E251 unexpected spaces around keyword / parameter equals
Line 61:79: E261 at least two spaces before inline comment
Line 67:28: E251 unexpected spaces around keyword / parameter equals
Line 67:30: E251 unexpected spaces around keyword / parameter equals
Line 67:92: E251 unexpected spaces around keyword / parameter equals
Line 67:94: E251 unexpected spaces around keyword / parameter equals
Line 69:48: E251 unexpected spaces around keyword / parameter equals
Line 69:50: E251 unexpected spaces around keyword / parameter equals
Line 69:53: E231 missing whitespace after ','
Line 73:77: E251 unexpected spaces around keyword / parameter equals
Line 73:79: E251 unexpected spaces around keyword / parameter equals
Line 73:82: E231 missing whitespace after ','
Line 73:84: E231 missing whitespace after ','
Line 73:100: E251 unexpected spaces around keyword / parameter equals
Line 73:102: E251 unexpected spaces around keyword / parameter equals
Line 73:115: E251 unexpected spaces around keyword / parameter equals
Line 73:117: E251 unexpected spaces around keyword / parameter equals
Line 73:145: E251 unexpected spaces around keyword / parameter equals
Line 73:147: E251 unexpected spaces around keyword / parameter equals
Line 75:1: W293 blank line contains whitespace
Line 77:17: E251 unexpected spaces around keyword / parameter equals
Line 79:19: E251 unexpected spaces around keyword / parameter equals
Line 87:46: E251 unexpected spaces around keyword / parameter equals
Line 87:48: E251 unexpected spaces around keyword / parameter equals
Line 87:110: E251 unexpected spaces around keyword / parameter equals
Line 87:112: E251 unexpected spaces around keyword / parameter equals
Line 90:73: E251 unexpected spaces around keyword / parameter equals
Line 90:75: E251 unexpected spaces around keyword / parameter equals
Line 90:78: E231 missing whitespace after ','
Line 90:80: E231 missing whitespace after ','
Line 90:96: E251 unexpected spaces around keyword / parameter equals
Line 90:98: E251 unexpected spaces around keyword / parameter equals
Line 90:111: E251 unexpected spaces around keyword / parameter equals
Line 90:113: E251 unexpected spaces around keyword / parameter equals
Line 90:141: E251 unexpected spaces around keyword / parameter equals
Line 90:143: E251 unexpected spaces around keyword / parameter equals
Line 92:1: W293 blank line contains whitespace
Line 94:13: E251 unexpected spaces around keyword / parameter equals
Line 96:15: E251 unexpected spaces around keyword / parameter equals
Line 103:7: W291 trailing whitespace
Line 106:34: E225 missing whitespace around operator
Line 106:102: E251 unexpected spaces around keyword / parameter equals
Line 106:104: E251 unexpected spaces around keyword / parameter equals
Line 107:47: E251 unexpected spaces around keyword / parameter equals
Line 107:49: E251 unexpected spaces around keyword / parameter equals
Line 107:81: E251 unexpected spaces around keyword / parameter equals
Line 107:139: W291 trailing whitespace
Line 109:29: E221 multiple spaces before operator
Line 109:57: E201 whitespace after '('
Line 109:68: E251 unexpected spaces around keyword / parameter equals
Line 109:70: E251 unexpected spaces around keyword / parameter equals
Line 109:101: E251 unexpected spaces around keyword / parameter equals
Line 109:103: E251 unexpected spaces around keyword / parameter equals
Line 109:135: E251 unexpected spaces around keyword / parameter equals
Line 109:137: E251 unexpected spaces around keyword / parameter equals
Line 109:172: E251 unexpected spaces around keyword / parameter equals
Line 109:174: E251 unexpected spaces around keyword / parameter equals
Line 111:31: E251 unexpected spaces around keyword / parameter equals
Line 112:32: E251 unexpected spaces around keyword / parameter equals
Line 112:52: E251 unexpected spaces around keyword / parameter equals
Line 112:54: E251 unexpected spaces around keyword / parameter equals

thibaultdvx and others added 8 commits November 7, 2024 09:37
@thibaultdvx @camillebrianceau
reset to solve rebase issue
ce26efb
@thibaultdvx @camillebrianceau
fix issue with enum
8182466
@thibaultdvx @camillebrianceau
fix numpy issue
06cf5e8
@thibaultdvx @camillebrianceau
Revert unwanted merge (aramis-lab#672)
663e489
@thibaultdvx @camillebrianceau
Basic neural networks (aramis-lab#660)
0b4381c 
* add customizable networks (MLP, ConvEncoder, ConvDecoder, CNN, Generator, AutoEncoder, VAE)

* add sota networks (ResNet, DenseNet, SE-ResNet, UNet, Attention-UNet, Vision Transformer)

*update config classes

*update factory function
@camillebrianceau
Cb extract validator (aramis-lab#666)
1ae7227
@camillebrianceau
Base for v2 (aramis-lab#676)
109ee64 
* base for clinicadl v2
@camillebrianceau
API ideas
c68eebd
@camillebrianceau camillebrianceau changed the base branch from refactoring to clinicadl_v2 November 7, 2024 08:39
thibaultdvx and others added 6 commits November 7, 2024 09:52
@thibaultdvx @camillebrianceau
fix issue with enum
418ccff
@thibaultdvx @camillebrianceau
fix numpy issue
8e122ab
@thibaultdvx @camillebrianceau
Revert unwanted merge (aramis-lab#672)
255cb22
@thibaultdvx @camillebrianceau
Basic neural networks (aramis-lab#660)
bd05e51 
* add customizable networks (MLP, ConvEncoder, ConvDecoder, CNN, Generator, AutoEncoder, VAE)

* add sota networks (ResNet, DenseNet, SE-ResNet, UNet, Attention-UNet, Vision Transformer)

*update config classes

*update factory function
@camillebrianceau
Cb extract validator (aramis-lab#666)
c0b79da
@camillebrianceau
Base for v2 (aramis-lab#676)
94b26d7 
* base for clinicadl v2
@camillebrianceau camillebrianceau deleted the cb_API branch November 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravih18 ravih18 Awaiting requested review from ravih18

@msolal msolal Awaiting requested review from msolal

@HuguesRoy HuguesRoy Awaiting requested review from HuguesRoy

@thibaultdvx thibaultdvx Awaiting requested review from thibaultdvx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camillebrianceau @pep8speaks @thibaultdvx