Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb extract validator #666

Merged

Conversation

camillebrianceau
Copy link
Collaborator

@camillebrianceau camillebrianceau commented Oct 9, 2024

In this PR:

  • The caps_directory is now optional because it is not needed for the predict and interpret commands when the data group is already defined.
  • Merged PredictManager and Validator into a single class, temporarily named Predictor.
  • Removed predict_multi as multi-network prediction can now be handled in predict_single.
  • Renamed SplitManager to Splitter.
  • Initialized the predictor and splitter in trainer.__init__().
  • Removed SSDA

@camillebrianceau camillebrianceau marked this pull request as ready for review October 9, 2024 09:14
@pep8speaks
Copy link

pep8speaks commented Oct 14, 2024

Hello @camillebrianceau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-18 11:02:18 UTC

@camillebrianceau camillebrianceau added the refactoring ClinicaDL refactoring 2024 label Oct 18, 2024
@camillebrianceau camillebrianceau requested review from thibaultdvx and removed request for thibaultdvx October 18, 2024 10:43
Copy link
Collaborator

@thibaultdvx thibaultdvx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camillebrianceau camillebrianceau merged commit d17ce05 into aramis-lab:refactoring Oct 18, 2024
21 checks passed
@camillebrianceau camillebrianceau deleted the cb_extract_validator branch October 18, 2024 11:26
camillebrianceau added a commit to camillebrianceau/clinicadl that referenced this pull request Nov 7, 2024
camillebrianceau added a commit to camillebrianceau/clinicadl that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ClinicaDL refactoring 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants