-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean MapsManager #658
Merged
camillebrianceau
merged 24 commits into
aramis-lab:refactoring
from
camillebrianceau:cb_init_maps
Oct 1, 2024
Merged
Clean MapsManager #658
camillebrianceau
merged 24 commits into
aramis-lab:refactoring
from
camillebrianceau:cb_init_maps
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @camillebrianceau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-01 13:49:26 UTC |
thibaultdvx
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except suspect prints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the training methods in the
trainer
module._train_multi
method. Now, thetrain_single
method is used for both single and multi-network training. In a future PR, we will need to apply the same approach to the_train_ssda
method.for split in split_manager.iterate():
andfor network in range(num_network):
out of thetrain_single
method. As a result, the new_train
method will be the entry point fortrainer.train()
.API_test.py
.TmpConfig
, which is currently unused but retained as a model for future reference.Next PR:
MapsManager
,Validator
, andSplitter
from thetrainer
.