Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term MRI in the glossary #1395

Conversation

maylistran01
Copy link
Contributor

MRI term and definition added from Wikipedia.
Closes #1384

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maylistran01 !
The PR LGTM !

@AliceJoubert It makes me realize that the snippet seems wrong by saying "Medical Resonance Imaging".

@AliceJoubert
Copy link
Contributor

Thanks @maylistran01 ! The PR LGTM !

@AliceJoubert It makes me realize that the snippet seems wrong by saying "Medical Resonance Imaging".

You're right. Do you want to fix it in this PR ?

@NicolasGensollen
Copy link
Member

Thanks @maylistran01 ! The PR LGTM !
@AliceJoubert It makes me realize that the snippet seems wrong by saying "Medical Resonance Imaging".

You're right. Do you want to fix it in this PR ?

@maylistran01 do you think you can do it ? You need to change this file: https://github.com/aramis-lab/clinica/blob/dev/docs/snippets/abbreviations.md and replace "Medical" with "Magnetic", make a new commit and push it.

Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @maylistran01 !

@NicolasGensollen NicolasGensollen merged commit 7436f44 into aramis-lab:dev Nov 27, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add term MRI to documentation glossary
3 participants