[ENH] Add new possibilities to pet-linear #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravih18
force-pushed
the
rh_improve_pet_linear
branch
from
a267944 to
97db324
Compare
|
Finally, after several tests, we decide to remove the node that removes the background and only keep the clipping of the background. |
NicolasGensollen
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
LGTM, thanks @ravih18 !
I'll do a quick follow up PR to:
- Refactor the function
clip_imgto separate the clipping logic from the threshold computation logic (the former is generic and could be used in other places in clinica while the latter is very specific) - Add some unit tests
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1346