Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Update contributing guidelines #1316

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[DOC] Update contributing guidelines #1316

merged 2 commits into from
Oct 9, 2024

Conversation

NicolasGensollen
Copy link
Member

Closes #1315

@NicolasGensollen NicolasGensollen self-assigned this Oct 9, 2024
@NicolasGensollen
Copy link
Member Author

Here is the rendered version: https://aramislab.paris.inria.fr/clinica/docs/public/PR-1316/Software/contributing/

@NicolasGensollen NicolasGensollen marked this pull request as ready for review October 9, 2024 09:21
AliceJoubert
AliceJoubert approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@AliceJoubert AliceJoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasGensollen ! That's very clear

@AliceJoubert AliceJoubert added the doc Documentation (wiki, source code, etc.) label Oct 9, 2024
@NicolasGensollen
Copy link
Member Author

Thanks for the review @AliceJoubert !
The unit test failures are unrelated so I'm gonna merge

@NicolasGensollen NicolasGensollen merged commit 45d02d7 into aramis-lab:dev Oct 9, 2024
12 of 15 checks passed
@NicolasGensollen NicolasGensollen deleted the add-pr-conventions-to-contributing branch October 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliceJoubert AliceJoubert AliceJoubert approved these changes

Assignees

@NicolasGensollen NicolasGensollen

Labels
doc Documentation (wiki, source code, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Improve contributing guidelines
2 participants
@NicolasGensollen @AliceJoubert