Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix some broken links in docs #1017

Merged

Conversation

NicolasGensollen
Copy link
Member

Fix some broken links and add some new links to the documentation.

Copy link
Contributor

@MatthieuJoulot MatthieuJoulot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NicolasGensollen ! some very needed changes in there !
I have a somewhat opposite view to what you did in the matter of the links you've given for BIDS and other references. I feel there is too many of them, and the text might look like a Christmas tree, which may not be so nice for the readers ? WDYT ? Opened to changing my mind !

docs/BIDS.md Outdated Show resolved Hide resolved
docs/Installation.md Outdated Show resolved Hide resolved
docs/InteractingWithClinica.md Show resolved Hide resolved
docs/InteractingWithClinica.md Show resolved Hide resolved
docs/InteractingWithClinica.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
@NicolasGensollen
Copy link
Member Author

Thanks for the review @MatthieuJoulot !

I realized there is already a list of converters on the index page which was already up-to-date. I made a link to this list instead of copy-pasting it multiple times in the "Interacting with clinica" page.

I also removed the multiple occurrences of links as you suggested.

Copy link
Contributor

@MatthieuJoulot MatthieuJoulot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@NicolasGensollen NicolasGensollen merged commit d7f39b0 into aramis-lab:dev Nov 24, 2023
14 of 17 checks passed
@NicolasGensollen NicolasGensollen deleted the fix-dead-link-in-docs branch November 24, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants