[FIX] Hardcode link and description for Genfi2BIDS
#1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Genfi2BIDSconverter parses the corresponding markdown file in the documentation to retrieve the project URL and description. This was implemented in order to avoid duplicating this information in the code.This works great when installing Clinica from source since the
docsfolder is cloned as being part of the repository. However, when installing a released version (pip install clinica), only the source code (i.e. content of theclinicafolder) is available insite-packages.This causes the converter to break when trying to retrieve the link and description.
This PR proposes to go back to hardcoding these in order to fix the converter while a more elegant solution is found.