Skip to content

Commit

Permalink
remove todo comments
Browse files Browse the repository at this point in the history
  • Loading branch information
novaknole committed Sep 10, 2024
1 parent 5ce8060 commit 84ef2cd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion packages/contracts/src/MajorityVotingBase.sol
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ abstract contract MajorityVotingBase is
_updateVotingSettings(_votingSettings);
}

// todo TBD define if permission should be the same one as update settings
/// @notice Updates the minimal approval value.
/// @param _minApprovals The new minimal approval value.
function updateMinApprovals(
Expand Down
1 change: 0 additions & 1 deletion packages/contracts/src/TokenVoting.sol
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ contract TokenVoting is IMembership, MajorityVotingBase {
emit MembershipContractAnnounced({definingContract: address(_token)});
}

// todo double check the reinitializer version must be 2
/// @notice Initializes the plugin after an upgrade from a previous version.
/// @param _minApprovals The minimal amount of approvals the proposal needs to succeed.
function initializeFrom(
Expand Down

0 comments on commit 84ef2cd

Please sign in to comment.