Skip to content

Commit

Permalink
Merge pull request #42 from aragon/feature/execute-into-iproposal
Browse files Browse the repository at this point in the history
Feature/execute into iproposal
  • Loading branch information
Rekard0 authored Nov 8, 2024
2 parents 1859ddf + a2d794a commit 5dee1b1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/contracts/src/MajorityVotingBase.sol
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,10 @@ abstract contract MajorityVotingBase is
_vote(_proposalId, _voteOption, account, _tryEarlyExecution);
}

/// @inheritdoc IMajorityVoting
function execute(uint256 _proposalId) public virtual auth(EXECUTE_PROPOSAL_PERMISSION_ID) {
/// @inheritdoc IProposal
function execute(
uint256 _proposalId
) public virtual override(IMajorityVoting, IProposal) auth(EXECUTE_PROPOSAL_PERMISSION_ID) {
if (!_canExecute(_proposalId)) {
revert ProposalExecutionForbidden(_proposalId);
}
Expand Down Expand Up @@ -401,7 +403,7 @@ abstract contract MajorityVotingBase is
/// @inheritdoc IMajorityVoting
function canExecute(
uint256 _proposalId
) public view virtual override(IMajorityVoting) returns (bool) {
) public view virtual override(IMajorityVoting, IProposal) returns (bool) {
if (!_proposalExists(_proposalId)) {
revert NonexistentProposal(_proposalId);
}
Expand Down

0 comments on commit 5dee1b1

Please sign in to comment.