Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified governance plugin setup #2

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Unified governance plugin setup #2

merged 4 commits into from
Nov 9, 2023

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Nov 8, 2023

The following PR introduces the following changes and improvements:

  • Combines the setup plugins for the MainVotingPlugin and the MemberAccessplugin into the new GovernancePluginSetup
    • It handles both plugins in one go
    • It handles the dependency between both plugins
  • Introduces convenience methods to encode and decode installation parameters
    • Available on each plugin setup
    • encodeInstallationParams and decodeInstallationParams
  • Updates the relevant testing, helpers and readme

@brickpop brickpop force-pushed the f/unified-governance-plugin-setup branch 2 times, most recently from 8a5f56d to 833f1ae Compare November 8, 2023 12:38
@brickpop brickpop merged commit 0fbb499 into main Nov 9, 2023
4 of 6 checks passed
@brickpop brickpop deleted the f/unified-governance-plugin-setup branch November 9, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brickpop