Skip to content

Commit

Permalink
Adapted tests
Browse files Browse the repository at this point in the history
  • Loading branch information
brickpop committed Jun 7, 2024
1 parent 8049bab commit b8c632b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
1 change: 0 additions & 1 deletion packages/contracts/src/governance/MemberAccessPlugin.sol
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ contract MemberAccessPlugin is IMultisig, PluginUUPSUpgradeable, ProposalUpgrade

/// @notice A container for the plugin settings.
/// @param proposalDuration The amount of time before a non-approved proposal expires.
/// @param mainVotingPlugin The address of the main voting plugin. Used to apply permissions for it.
struct MultisigSettings {
uint64 proposalDuration;
}
Expand Down
12 changes: 5 additions & 7 deletions packages/contracts/test/unit-testing/member-access-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const defaultInitData: InitData = {
};

export const multisigInterface = new ethers.utils.Interface([
'function initialize(address,tuple(uint64,address))',
'function initialize(address,tuple(uint64))',
'function updateMultisigSettings(tuple(uint64))',
'function proposeAddMember(bytes,address,address)',
'function getProposal(uint256)',
Expand Down Expand Up @@ -1090,12 +1090,10 @@ describe('Member Access Plugin', function () {
);
await expect(
mainVotingPlugin.proposeAddMember(EMPTY_DATA, carol.address)
)
.to.revertedWithCustomError(
memberAccessPlugin,
'ProposalCreationForbiddenOnSameBlock'
)
.withArgs(alice.address);
).to.revertedWithCustomError(
memberAccessPlugin,
'ProposalCreationForbiddenOnSameBlock'
);

await ethers.provider.send('evm_setAutomine', [true]);
});
Expand Down

0 comments on commit b8c632b

Please sign in to comment.