Skip to content

Commit

Permalink
Minor edits
Browse files Browse the repository at this point in the history
  • Loading branch information
brickpop committed May 27, 2024
1 parent 72ee450 commit b8b5ea5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/contracts/src/governance/MainVotingPlugin.sol
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ contract MainVotingPlugin is Addresslist, MajorityVotingBase, IEditors, IMembers
emit MemberRemoved(address(dao()), _account);
}

/// @notice Removes msg.sender from the list of editors. If the last editors leaves the space, the space will become read only.
function leaveSpace() public {
/// @notice Removes msg.sender from the list of editors and members, whichever is applicable. If the last editor leaves the space, the space will become read-only.
function leaveSpace() external {
if (isEditor(msg.sender)) {
// Not checking whether msg.sender is the last editor. It is acceptable
// that a DAO/Space remains in read-only mode, as it can always be forked.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ contract PersonalSpaceAdminPlugin is PluginCloneable, ProposalUpgradeable, IEdit
}

/// @notice Creates and executes a proposal that makes the DAO revoke any permission from the sender address
function leaveSpace() public {
function leaveSpace() external {
IDAO.Action[] memory _actions;
if (dao().hasPermission(address(this), msg.sender, MEMBER_PERMISSION_ID, bytes(""))) {
_actions = new IDAO.Action[](1);
Expand Down

0 comments on commit b8b5ea5

Please sign in to comment.