Skip to content

Commit

Permalink
Minor edits
Browse files Browse the repository at this point in the history
  • Loading branch information
brickpop committed Apr 15, 2024
1 parent a2c4806 commit 28e6b52
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions README_DEPLOYMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Back to this repository:
```sh
cd packages/contracts
yarn build
npx hardhat deploy --network <the-network-name>
yarn deploy --network <the-network-name>
```

#### 3) Install a governance plugin to the Managing DAO
Expand Down Expand Up @@ -109,12 +109,12 @@ MGMT_DAO_PROPOSAL_SUPPORT_THRESHOLD="500000" # 50%
MGMT_DAO_INITIAL_EDITORS="0x1234,0x2345,0x3456,0x4567..." # Comma separated addresses
3) Run the following command:
$ npx ts-node scripts/managing-dao-setup.ts
$ yarn managing-dao-setup
```

By running the `managing-dao-setup.ts` script, you will be:

1. Asking the [PSP from OSx](#1-deploy-osx) to run `prepareInstallation()` and deploy a new Governance plugin instance
2. Ask the Managing DAO to `execute()` an action that calls `applyInstallation()` of the deployed plugin
3. Calling `execute()` on the Managing DAO so that the deployment wallet can no longer execute actions on the DAO
2. Ask the Managing DAO to call `applyInstallation()` on the PSP for the deployed plugin
3. Make the Managing DAO revoke the remaining deployment wallet permissions
4. Checking that the Managing DAO's permissions are correctly configured
1 change: 1 addition & 0 deletions packages/contracts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
"build": "cross-env TS_NODE_TRANSPILE_ONLY=true hardhat compile",
"coverage": "hardhat coverage --solcoverjs ./.solcover.js --temp artifacts --testfiles \"test/**/*.ts\" && yarn typechain",
"deploy": "hardhat deploy",
"managing-dao-setup": "ts-node scripts/managing-dao-setup.ts",
"lint": "yarn lint:sol && yarn lint:ts",
"lint:sol": "solhint \"src/**/*.sol\"",
"lint:ts": "eslint --ignore-path ./.eslintignore --ext .js,.ts .",
Expand Down

0 comments on commit 28e6b52

Please sign in to comment.