Merge branch 'daredevil' of github.com:arafune/arpes into daredevil

pyproject.toml

@@ -96,6 +96,7 @@ lint.ignore = [
   "G004",   # logging-f-string
   #
   "NPY201", #  Numpy 2.0, 
+  "ISC001", # single-line-implicit-string-concatenation
 ]
 lint.select = ["ALL"]
 target-version = "py311"

src/arpes/analysis/band_analysis.py

@@ -7,6 +7,7 @@
 import functools
 import itertools
 from itertools import pairwise
+from logging import DEBUG, INFO, Formatter, StreamHandler, getLogger
 from typing import TYPE_CHECKING, Any, Literal
 
 import numpy as np
@@ -36,6 +37,18 @@
     "fit_for_effective_mass",
 )
 
+LOGLEVELS = (DEBUG, INFO)
+LOGLEVEL = LOGLEVELS[1]
+logger = getLogger(__name__)
+fmt = "%(asctime)s %(levelname)s %(name)s :%(message)s"
+formatter = Formatter(fmt)
+handler = StreamHandler()
+handler.setLevel(LOGLEVEL)
+logger.setLevel(LOGLEVEL)
+handler.setFormatter(formatter)
+logger.addHandler(handler)
+logger.propagate = False
+
 
 def fit_for_effective_mass(
     data: xr.DataArray,

src/arpes/plotting/fit_tool/__init__.py

@@ -266,7 +266,7 @@ def configure_image_widgets(self) -> None:
                 layout=self.content_layout,
             )
 
-    def generate_fit_marginal_for(
+    def generate_fit_marginal_for(  # noqa: PLR0913
         self,
         dimensions: tuple[int, ...],
         column_row: tuple[int, int],

src/arpes/plotting/qt_tool/__init__.py

@@ -552,7 +552,7 @@ def set_data(self, data: xr.DataArray) -> None:
 def _qt_tool(data: XrTypes, **kwargs: Incomplete) -> None:
     """Starts the qt_tool using an input spectrum."""
     with contextlib.suppress(TypeError):
-        data = dill.loads(data)
+        data = dill.loads(data)  # noqa: S301
 
     tool = QtTool()
     tool.set_data(data)

src/arpes/plotting/stack_plot.py

@@ -65,7 +65,7 @@
 
 
 @save_plot_provenance
-def offset_scatter_plot(
+def offset_scatter_plot(  # noqa: PLR0913
     data: xr.Dataset,
     name_to_plot: str = "",
     stack_axis: str = "",
@@ -133,7 +133,7 @@ def offset_scatter_plot(
     skip_colorbar = True
     if cbarmap is None:
         skip_colorbar = False
-        cbar: colorbar.Colorbar | Callable[..., colorbar.Colorbar]
+        cbar: Callable[..., colorbar.Colorbar]
         cmap: Callable[..., ColorType] | Callable[..., Callable[..., ColorType]]
         try:
             cbar, cmap = colorbarmaps_for_axis[stack_axis]

src/arpes/utilities/widgets.py

@@ -138,7 +138,7 @@ def __init__(self, *args: QWidget | None) -> None:
         self.toggled.connect(lambda: self.subject.on_next(self.isChecked()))
         self.subject.subscribe(self.update_ui)
 
-    def update_ui(self, value: bool) -> None:
+    def update_ui(self, *, value: bool) -> None:
         """Forwards value change to the UI."""
         self.setChecked(value)