Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing memory invariance #263

Draft
wants to merge 1 commit into
base: PE-7211_invariant_checks
Choose a base branch
from

Conversation

atticusofsparta
Copy link
Contributor

To add the current memory from the cu for both testnet and devnet, you can run yarn update-memory-fixtures - these are not included by default because they are quite large (300mb+).

This PR is setup to run with testnet memory - the current WASM binary used in the tests matches this memory and works.

If you attempt to run with devnet it will not work - this is likely because one memory is from a wasm64 module (testnet) and devnet is a wasm32 module.

Further testing would be required to identify if this is the issue, but also just as likely that simply being different modules make the memory incompatible (not just because they are different build types)

Further work:

If it is desired to have invariance testing with existing memory on both, simply add a network ENV var and conditionaly read the target AOS_WASM and existing memory fixtures.

@atticusofsparta atticusofsparta changed the base branch from develop to PE-7211_invariant_checks December 10, 2024 19:18
@atticusofsparta atticusofsparta marked this pull request as draft December 10, 2024 19:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (0307691) to head (60b51af).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           PE-7211_invariant_checks     #263      +/-   ##
============================================================
- Coverage                     95.67%   95.52%   -0.15%     
============================================================
  Files                            11       10       -1     
  Lines                          2934     2882      -52     
============================================================
- Hits                           2807     2753      -54     
- Misses                          127      129       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants