Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primary names): update Remove-Primary-Names message to use comma delimited list #41

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix(primary names): update Remove-Primary-Names message to use comma delimited list #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dbd1a3
fix(primary names): fix remove primary names
atticusofsparta Nov 25, 2024
d6f8bad
fix(remove names): update primary names messages to send as comma del…
atticusofsparta Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ function ant.init()
ao.send({
Target = ioProcess,
Action = "Remove-Primary-Names",
Names = json.encode(names),
Names = msg.Tags.Names,
})
end)
end
Expand Down
2 changes: 1 addition & 1 deletion test/primary_names.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('Primary Names', async () => {

assert.strictEqual(removePrimaryNamesMsg.Target, ''.padEnd(43, '2'));
assert.strictEqual(actionTag.value, 'Remove-Primary-Names');
assert.strictEqual(namesTag.value, JSON.stringify(names));
assert.strictEqual(namesTag.value, names.join(','));
});
it('should not send remove names request if caller not owner', async () => {
const names = ['foo', 'bar', 'baz'];
Expand Down
Loading