Merge pull request smeup#1976 from smeup/drop-fix

fix: improved cell retrieval information on drop
apuliasoft · Jul 2, 2024 · e3f7101 · e3f7101
2 parents 630821a + 2561ecb
commit e3f7101
Showing 1 changed file with 18 additions and 12 deletions.
diff --git a/packages/ketchup/src/components/kup-data-table/kup-data-table.tsx b/packages/ketchup/src/components/kup-data-table/kup-data-table.tsx
@@ -2124,7 +2124,7 @@ export class KupDataTable {
                     if (!cell) {
                         this.#kupManager.debug.logMessage(
                             this,
-                            "Couldn't find cell hovered to retrieve dropzone informations!",
+                            "Couldn't find cell to retrieve drag informations!",
                             KupDebugCategory.WARNING
                         );
                         return;
@@ -2161,26 +2161,22 @@ export class KupDataTable {
         }
         if (this.dropEnabled) {
             const dataCb: KupDropDataTransferCallback = () => {
-                const cell =
-                    this.rootElement.shadowRoot.querySelector('td:hover');
+                const cell = this.#lastPointerDetails?.cell;
+                const column = this.#lastPointerDetails?.column;
+                const row = this.#lastPointerDetails?.row;
                 if (!cell) {
                     this.#kupManager.debug.logMessage(
                         this,
-                        "Couldn't find cell hovered to retrieve dropzone informations!",
+                        "Couldn't find cell to retrieve dropzone informations!",
                         KupDebugCategory.WARNING
                     );
                     return;
                 }
-                const path = this.#kupManager.getEventPath(
-                    cell,
-                    this.rootElement
-                );
-                const receivingDetails = this.#getEventDetails(path);
                 return {
-                    cell: receivingDetails.cell,
-                    column: receivingDetails.column,
+                    cell,
+                    column,
                     id: this.rootElement.id,
-                    row: receivingDetails.row,
+                    row,
                 };
             };
             for (let index = 0; index < this.#rowsRefs.length; index++) {
@@ -5873,6 +5869,16 @@ export class KupDataTable {
                                         e as unknown as Interact.PointerEvent
                                     );
                             }}
+                            onPointerUp={(e) => {
+                                this.#lastPointerDetails =
+                                    this.#getEventDetails(
+                                        this.#kupManager.getEventPath(
+                                            e.target,
+                                            this.rootElement
+                                        ),
+                                        e as unknown as Interact.PointerEvent
+                                    );
+                            }}
                             onContextMenu={(e: MouseEvent) => {
                                 e.preventDefault();
                             }}