Merge pull request smeup#2045 from apuliasoft/bugfix/button-key-disco…

…nnected bugfix(kup-button): added key shortcut checks
apuliasoft · Sep 5, 2024 · e3826b8 · e3826b8
2 parents af636ba + ad5e525
commit e3826b8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/ketchup/src/components/kup-button/kup-button.tsx b/packages/ketchup/src/components/kup-button/kup-button.tsx
@@ -364,6 +364,9 @@ export class KupButton {
 
     disconnectedCallback() {
         this.kupManager.theme.unregister(this);
-        this.kupManager.keysBinding.unregister(this.keyShortcut);
+
+        if (this.keyShortcut) {
+            this.kupManager.keysBinding.unregister(this.keyShortcut);
+        }
     }
 }
diff --git a/packages/ketchup/src/managers/kup-keys-binding/kup-keys-binding.ts b/packages/ketchup/src/managers/kup-keys-binding/kup-keys-binding.ts
@@ -25,6 +25,10 @@ export class KupKeysBinding {
      * @param {GenericCallback} event - Event to start when key is pressed
      */
     register(key: string, event: GenericCallback): void {
+        if (!key || !event) {
+            return;
+        }
+
         this.#keysEvents.set(key.toLowerCase(), { event, isLunched: false });
     }
 
@@ -33,6 +37,9 @@ export class KupKeysBinding {
      * @param {string} key - Key to remove.
      */
     unregister(key: string): void {
+        if (!key) {
+            return;
+        }
         this.#keysEvents.delete(key.toLowerCase());
     }