Bugfix for Ubuntu & reload over restart for faster config updates #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yourabi
force-pushed
the
master
branch
4 times, most recently
from
dadcde5 to
fa5f017
Compare
|
It was probably /bin/sh out of habit and that /bin/sh is the system (posix compliant) shell... Have you tested this out? Glancing at recipes/default.rb I wonder how monit would handle "reload" vs "start" on a node's firstboot? In principal I think a version of this with reduced scope could be interested (reload vs restart on template render / config change) |
yourabi
force-pushed
the
master
branch
2 times, most recently
from
ffa7522 to
ac3793f
Compare
|
Would it be possible to just have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Two changes are in this pull. We had made this fork a while ago, so I'm happy to update / rebase if need be. However, I wanted to see if this would be friendly before I do.
a) We updated the config updates to cause a reload rather than restart, for performance reasons. This should be fine, and I would think is preferable, but let me know if you disagree.
b) Ubuntu's default shell isn't bash (see discussion on that commit). The best practice should be to use
/usr/bin/envto find the bash location.Any concerns/ comments?