Merge pull request #20 from Lytro/make_email_alerts_optional

only set email alerts if node[:monit][:notify_email] is not nil (defaults to nil)

attributes/default.rb

@@ -1,4 +1,4 @@
-default["monit"]["notify_email"]          = "[email protected]"
+default["monit"]["notify_email"]          = nil
 default["monit"]["alert_blacklist"]       = %w( action instance pid ppid )
 
 default["monit"]["logfile"]               = 'syslog facility log_daemon'

spec/unit/recipes/default_spec.rb

@@ -2,9 +2,7 @@
 
 describe 'monit::default' do
   context "with default attributes" do
-    let(:chef_run) do
-      runner = ChefSpec::Runner.new.converge(described_recipe)
-    end
+    let(:chef_run) { ChefSpec::Runner.new.converge(described_recipe) }
 
     it 'creates /etc/monit/conf.d/' do
       expect(chef_run).to create_directory('/etc/monit/conf.d/').with(user: 'root', group: 'root', mode: 0755)
@@ -27,6 +25,10 @@
     it 'start the service' do
       expect(chef_run).to start_service('monit') 
     end
+
+    it 'does not email notifications' do
+      expect(chef_run).not_to render_file('/etc/monit/monitrc').with_content(/set alert /)
+    end
   end
 
   context "with configuration" do

templates/default/monitrc.erb

@@ -31,7 +31,9 @@ set mail-format {
   message: <%= @node["monit"]["mail_format"]["message"] %>
 }
 
-set alert <%= @node["monit"]["notify_email"] %><%= " NOT ON { #{@node["monit"]["alert_blacklist"].join(", ")} }" unless @node["monit"]["alert_blacklist"].empty? %>
+<% unless @node[:monit][:notify_email].nil? %>
+  set alert <%= @node["monit"]["notify_email"] %><%= " NOT ON { #{@node["monit"]["alert_blacklist"].join(", ")} }" unless @node["monit"]["alert_blacklist"].empty? %>
+<% end %>
 
 set httpd port <%= @node["monit"]["port"] %>
   <%= "use address #{@node["monit"]["address"]}" if @node["monit"]["address"] %>