Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDK Method Multiplexing #1014

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement SDK Method Multiplexing #1014

wants to merge 2 commits into from

Conversation

PineappleIOnic
Copy link
Member

What does this PR do?

This PR implements route multiplexing for supporting multiple methods being created from one API.

Have you read the Contributing Guidelines on issues?

Yes

@PineappleIOnic PineappleIOnic mentioned this pull request Dec 10, 2024
Open
2 tasks
abnegate
abnegate reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of nesting in the getMethods function, let's try to negate some cases and have early continues/returns to reduce the nesting

src/Spec/Swagger2.php Show resolved Hide resolved
src/Spec/Swagger2.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abnegate abnegate Awaiting requested review from abnegate

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PineappleIOnic @abnegate