Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

chore: Release PR #741

Merged
merged 5 commits into from
Jun 13, 2024
Merged

chore: Release PR #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec93be4
Update DesignTokens.mdx
vasanthappsmith Jun 5, 2024
18850f5
feat: added icon for git-repository
brayn003 Jun 12, 2024
fb7a979
Create great-pets-develop.md
albinAppsmith Jun 13, 2024
bccd890
Merge pull request #740 from appsmithorg/chore/add-icon-git-repo
albinAppsmith Jun 13, 2024
dff76d1
Merge pull request #739 from appsmithorg/vasanthappsmith-patch-5
albinAppsmith Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-pets-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@appsmithorg/design-system": patch
---

chore: adding icon for git-repository
5 changes: 0 additions & 5 deletions packages/design-system/src/Documentation/DesignTokens.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ You will find tokens defined in the following format in Figma.
(Note: The exact name in Figma would be **color/ui/content/surface/default/bg.** This is due to how the tokens were defined in JSON for exporting to Token studio. We will correct this once we figure out how to do this well. In any case, if you search for a token — you will see it show up properly in Figma’s property pane.)

[//]: # (TODO: How to embed this page so the preview shows?)
https://www.figma.com/file/5QitVVvqgEc6nhR7SbdinY/ADS2.0---Tokens?node-id=2507%3A46415&t=aLuYuSiYCsg7nxad-4

## How to style?

Expand Down Expand Up @@ -168,10 +167,6 @@ A product’s UI comprises of headings, body, captions in the content category.

The following tokens have been defined for the headings category

https://www.figma.com/file/5QitVVvqgEc6nhR7SbdinY/ADS2.0---Tokens?node-id=2137%3A33642&t=aLuYuSiYCsg7nxad-4

https://www.figma.com/file/5QitVVvqgEc6nhR7SbdinY/ADS2.0---Tokens?node-id=2137%3A33722&t=aLuYuSiYCsg7nxad-4

> ☝️ For every ui-category **type** token.. there is a color token associated with it. For example, the `Page Heading` type will necessarily use the gray-800 color token. This is the color you should be using. However, in code all of these values will be available as one if the correct type is passed to `Text`.

To make things even simpler for designers, we now have a Text component defined in Figma. Simply drag the component to Figma’s canvas and enter your text.
Expand Down
4 changes: 4 additions & 0 deletions packages/design-system/src/Icon/Icon.provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ const GitCommit = importRemixIcon(
const GitPullRequest = importRemixIcon(
() => import("remixicon-react/GitPullRequestLineIcon"),
);
const GitRepository = importRemixIcon(
() => import("remixicon-react/GitRepositoryLineIcon"),
)
const GlobalLineIcon = importRemixIcon(
() => import("remixicon-react/GlobalLineIcon"),
);
Expand Down Expand Up @@ -1131,6 +1134,7 @@ const ICON_LOOKUP = {
"git-branch": GitBranchLineIcon,
"git-commit": GitCommit,
"git-pull-request": GitPullRequest,
"git-repository": GitRepository,
"global-line": GlobalLineIcon,
"group-2-line": Group2LineIcon,
"group-line": GroupLineIcon,
Expand Down
Loading