Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

fix: Radio, Checkbox - child span issue #693

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

albinAppsmith
Copy link
Contributor

Description

Radio button and Checkbox was rendering the radio/checkbox twice when a tag component is passed as children. This was because of the css selectors inside these two component where checking for any span element. Added respective classnames to these to fix the issue.

Fixes appsmithorg/appsmith#28889

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: e8d0e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 11:23am

@github-actions github-actions bot added bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Production Super Admin DevOps Pod labels Jan 17, 2024
@albinAppsmith
Copy link
Contributor Author

/generate-alpha

Copy link
Contributor

Publish Result: @appsmithorg/[email protected]

@albinAppsmith albinAppsmith merged commit 9f01bd0 into release Jan 17, 2024
11 checks passed
@albinAppsmith albinAppsmith deleted the fix-radio-span-issue branch January 17, 2024 11:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working DevOps Pod High This issue blocks a user from building or impacts a lot of users Needs Triaging Production Super Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Admin settings -> General - > Embed Settings - "Not recommended" text cut off
2 participants