This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Update random number generator to use C++11 standard library #3344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our random number generator uses boost random library, which has largely been supplanted by C++11. This PR updates the random number tools to use the C++11 intrinsics.
This change is needed to allow us to transition to C++17. In c++17, std::random_shuffle is removed in place of std::shuffle, which is no longer compatible with the boost random generators. This requires us to change the base random generators to the c++11 versions, and thus swap out the distributions to the c++11. After this PR, we no longer depend on boost random.
The c++11 versions allow us to simplify a couple of things: