Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Fixed issues in python toolchain setup script. #3337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed issues in python toolchain setup script. #3337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/install_python_toolchain.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -exo pipefail

if [[ -z $VIRTUALENV ]]; then
VIRTUALENV=virtualenv
VIRTUALENV='python3 -m venv'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to support Python 2.7. I don't think this is going to work for Python 2.7

fi

$VIRTUALENV "$(pwd)"/deps/env
Expand Down Expand Up @@ -63,7 +63,7 @@ fi

echo "run 'ln -Ffs' files from ${SRC_INCLUDE_DIR}"
for f in $SRC_INCLUDE_DIR/*; do
ln -Ffs "$f" "$(basename "$f")"
ln -Ffs "$f" "$(basename "$f")" || echo "Warning: error installing symlink for $f."
done

popd
Expand All @@ -73,7 +73,7 @@ pushd deps/local/bin

echo "run 'ln -Ffs' on files from ../../env/bin/"
for f in ../../env/bin/*; do
ln -Ffs "$f" "$(basename "$f")"
ln -Ffs "$f" "$(basename "$f")" || echo "Warning: error installing symlink for $f."
done

popd
Expand Down