-
Notifications
You must be signed in to change notification settings - Fork 1.1k
better progress report #3117
base: main
Are you sure you want to change the base?
better progress report #3117
Conversation
@guihao-liang - As we discussed it would in person, it would be better if progress was reported at fixed time interval rather then every time a 64MB block is uploaded/downloaded. Here is an example of where we do something like that in the Python layer. |
Thanks! I already had my own implementation yesterday. But it's pretty similar. I think a better solution is to have a separate thread reporting every 20s. But I have no time. This should be my last S3 PR. I need to work on other stuff. |
A possible solution. 80% finished. Feel free to pick it up. |
ca4f444
to
471b0b9
Compare
passed internally. Job id 112426. |
c5ec0b1
to
e163555
Compare
update 05/08/2020
implemented a thread-safe stopwatch to measure the elapsed time spent by concurrent IO.
report progress to users in order to let them wait for slow IO operations. Reduce the chance that users think the program is hanging without progress.
Tries to solve #3119. But due to the fact that we should provide prompt based on elapsed time. Anyway, we should have metrics inside of the SFrame by remembering how many bytes are downloaded and tell the user the progress.
update
upload
05/08/2020
download
a prompt based on time interval.