This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
[WIP] New build system. #2877
Open
[WIP] New build system. #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoytak
requested review from
ylow,
TobyRoseman,
znation,
guihao-liang and
nickjong
TobyRoseman
reviewed
Jan 2, 2020
| echo " --target-dir, -t The target directory to install artifact to." | ||
| echo " default: `pwd`/targets." | ||
| echo | ||
| echo " --release Build in release mode." |
There was a problem hiding this comment.
It doesn't look like debug or release is actually getting used any where.
There was a problem hiding this comment.
by default is release. Just add --debug should be fine.
znation
approved these changes
Jan 2, 2020
guihao-liang
approved these changes
Jan 3, 2020
Rearchitecture of the the build system. A vast simplification. Changes - ./configure can produce an XCode project of the Turi source code. - deps/ can be compiled and installed out of the regular build process. Helpful for the XCode project. - All packages in src/external/ and src/visualization compile into static libraries. - The rest of the code base compiles into a single shared library. This means that most everything occurs in one single CMakeLists.txt file using standard cmake commands. - All headers are installed into targets/include when `make install` is called. The main library is installed into targets/lib. - The code definitions that reflect compiler oddities (e.g. is std::hash<int128_t> defined) are dumped into a single header file, src/turi_common.h. All source files and headers include this file first. This allows other programs to link against this library / headers reliably. - The python part of TuriCreate now builds through the standard setup.py method. Cython / pybind11 extensions are compiled and packaged using the standard extensions mechanisms and linking against the installed Turi headers. WIP TODO: the python installation, deployment.
| echo " --target-dir, -t The target directory to install artifact to." | ||
| echo " default: `pwd`/targets." | ||
| echo | ||
| echo " --release Build in release mode." |
There was a problem hiding this comment.
by default is release. Just add --debug should be fine.
| @@ -0,0 +1,112 @@ | |||
| #!/bin/bash -e | |||
There was a problem hiding this comment.
is this file intended to be used interactively? like, configure?
There was a problem hiding this comment.
Eh, this one seem deprecated. scripts/make_wheel.sh is better I think? Not sure.
There was a problem hiding this comment.
this one uses make_wheel.sh. I don't know if this is just for the manual interactive build.
|
forked in #3065. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearchitecture of the the build system. A vast simplification.
Changes
make installis called. The main library is installed into targets/lib.WIP TODO: The python installation, deployment building.
To review: Essentially it's all in the root CMakeLists.txt file, with some changes to ./configure. Just focus on those two.