[Refactor] Introduce TranslatorContext (2/2) #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Depends on #638, so don't review until that lands.
Continuation of #638, broke up into multiple PRs for easier review.
Also a non-functional change, purely a refactoring.
Modifications
Changed a bunch of TypeMatcher methods from static to being instance methods, which gives them access to the translator context.
Moved a few other methods that depended on the static methods to be extensions on the closest type that already has access to the context.
Result
Now TypeAssigner/TypeMatcher can take runtime configuration, e.g. through feature flags.
Test Plan
All tests still pass.