Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] SOAR-0011: Improved error handling #626

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

gayathrisairam
Copy link
Contributor

Motivation

Swift OpenAPI runtime doesn't allow for fine grained error handling. This PR adds a proposal for improved error handling in Swift OpenAPI runtime.

Modifications

  • Add SOAR-011: Improved error handling.
    (See the proposal for details)

Result

n/a

Test Plan

n/a

@czechboy0
Copy link
Contributor

Please also add a link to it in the Proposals.md file 🙂

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you @gayathrisairam!

Added a few comments that are meant to help prepare the proposal for review (I'll hold off on commenting on the proposal itself for the review period).

Once you make these updates, we'll be able to send out the proposal for wider review.

@simonjbeaumont simonjbeaumont added kind/proposal Proposals for review. labels Sep 17, 2024
@gayathrisairam
Copy link
Contributor Author

Please also add a link to it in the Proposals.md file 🙂

Link to what?

@czechboy0
Copy link
Contributor

Please also add a link to it in the Proposals.md file 🙂

Link to what?

Here, a link to your proposal:

@czechboy0 czechboy0 changed the title Proposal for error handling [Proposal] SOAR-0011: Improved Error Handling Sep 19, 2024
@czechboy0 czechboy0 changed the title [Proposal] SOAR-0011: Improved Error Handling [Proposal] SOAR-0011: Improved error handling Sep 19, 2024
@czechboy0
Copy link
Contributor

The proposal is now In Review, forums thread: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736

@czechboy0
Copy link
Contributor

This proposal is now Ready for Implementation, see details on the forums: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736/31

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing now, we'll update the status once we have a Runtime release with this feature included.

@czechboy0 czechboy0 enabled auto-merge (squash) November 22, 2024 07:04
@czechboy0 czechboy0 merged commit 3ecfcfa into apple:main Nov 22, 2024
34 checks passed
@czechboy0 czechboy0 added the semver/none No version bump required. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/proposal Proposals for review. semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants