Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Call the Soundness workflow #603

Closed
wants to merge 3 commits into from

Conversation

shinGangan
Copy link

Motivation

Observed all the workflows failed.

After examining the cause, the file name of the workflow used was changed. The PR where the file name has been changed is as follows.

Modifications

The file name has been changed to the correct one.

Also, benchmarks_linux_enabled was deleted in this PR. Therefore, with.benchmarks_linux_enabled was deleted.

Result

The workflow will move normally.

@shinGangan
Copy link
Author

shinGangan commented Jul 23, 2024

Hi, swift-openapi-generator developer team 👋
Please review when the reviewer has time. 🙏

Thank you for your great work and development.

Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this! Just one nit

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
Co-authored-by: Franz Busch <[email protected]>
@czechboy0
Copy link
Contributor

@FranzBusch please lmk if this is good to go and I can kick off the CI and merge if all is green

@shinGangan
Copy link
Author

Hello @FranzBusch , are there any additional changes to be made to this PR? If so, we will address them.

@FranzBusch
Copy link
Member

@shinGangan This PR should probably be closed in favour of #604

@simonjbeaumont
Copy link
Contributor

Thanks for taking the time to help here @shinGangan. I'm closing this PR and I'm sorry about how long it took to get around to it and for the overlap between your work and Franz'. :)

@shinGangan
Copy link
Author

Hello @simonjbeaumont , thanks for your comment!
I'll continue to contribute where I can. ;)

@shinGangan shinGangan deleted the refactor/change-gha-uses branch September 17, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants