Separate public/private keys and signatures into protocol conformances #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As it's currently intended, this PR is regarded a precursor to a PR that allows users to register their own public/private key types. I intend to follow up with that shortly. |
Lukasa
reviewed
Mar 26, 2024
Sources/NIOSSH/Keys And Signatures/CryptoKit+PublicKeyProtocols.swift
Outdated
Show resolved
Hide resolved
Joannis
force-pushed
the
feature/jo/public-private-key-protocols
branch
from
3adb0aa
to
8bd14e5
Compare
|
Is there anything blocking this? I'd love to have this 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, all the supported public/private key implementations are deeply integrated with NIOSSH through the internal enums that NIOSSH relies on. This PR moves that responsibility into a protocol conformance, paving the way towards custom public/private key types - and therefore moving towards supporting older/insecure standards such as RSA.