-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grpc-protoc] Add an option to generate default service methods #3110
Open
mgodave
wants to merge
11
commits into
apple:main
Choose a base branch
from
mgodave:drusek/default-service-implementations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[grpc-protoc] Add an option to generate default service methods #3110
mgodave
wants to merge
11
commits into
apple:main
from
mgodave:drusek/default-service-implementations
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 60ac59d - Browse repository at this point
Copy the full SHA 60ac59dView commit details -
Add option to the protoc code generator to avoid generating deprecate…
…d code (apple#3089) ### Motivation The generated ServiceTalk gRPC stubs make use of deprecated calls. This causes a problem when `-Werror` is used to build the code since it will automatically fail the build. We should allow users who have already migrated their code to prevent the protoc compiler from generating and using deprecated references. ### Modifications Add an option, `skipDeprecated`, as part of the protoc compiler configuration, to tell the generator to leave out deprecated references. Remove - initSerializationProvider, reason: ContentCodec is deprecated - isSupportedMessageCodingsEmpty, reason ContentCodec is deprecated - Deprecated ServiceFactory constructors - ServiceFactory::Builder references to ContentCodec - Generated client metadata and associated methods, reason: deprecated ### Result Users can generate gRPC stubs without deprecated code. ### Testing Manually tested: - Add new option to ServiceTalk/examples/grpc/protoc-options and use it to generate test_service.proto which covers all combinations of streaming (or not) services.
Configuration menu - View commit details
-
Copy full SHA for cc93b8a - Browse repository at this point
Copy the full SHA cc93b8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed1fe5 - Browse repository at this point
Copy the full SHA 7ed1fe5View commit details
Commits on Nov 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2d1688 - Browse repository at this point
Copy the full SHA c2d1688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7845ebb - Browse repository at this point
Copy the full SHA 7845ebbView commit details
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9120c33 - Browse repository at this point
Copy the full SHA 9120c33View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 49ebbe2 - Browse repository at this point
Copy the full SHA 49ebbe2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c4b42c - Browse repository at this point
Copy the full SHA 2c4b42cView commit details
Commits on Dec 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 58c586b - Browse repository at this point
Copy the full SHA 58c586bView commit details -
Revert "refactor how we determine which methods need a default implem…
…entation" This reverts commit 49ebbe2.
Configuration menu - View commit details
-
Copy full SHA for 9aa486b - Browse repository at this point
Copy the full SHA 9aa486bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44985b0 - Browse repository at this point
Copy the full SHA 44985b0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.