Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEE-462: re-write Badge to use badge-{color} classes #1228

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

aaronmars
Copy link
Contributor

  • Re-writes the Badge component without using the reactstrap implementation
  • Uses badge-{color} for the color classes (reactstrap uses bg-{color})

This re-write attempts to maintain backward compatibility with the reactstrap implementation. If Badge is ever re-written in a non-backward compatible way, it will be added to react-libs so there is a migration path.

Copy link

kermitapp bot commented Mar 27, 2024

@aaronmars aaronmars requested a review from a team March 27, 2024 18:24
Copy link
Contributor

Released prerelease version 8.11.2-FEE-462-Fix-badge-BG-colors-in-react-gears-0a34af8.0.
You may now run npm install @appfolio/react-gears@FEE-462-Fix-badge-BG-colors-in-react-gears

@aaronmars aaronmars merged commit c920062 into master Mar 28, 2024
4 checks passed
@aaronmars aaronmars deleted the FEE-462-Fix-badge-BG-colors-in-react-gears branch March 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants