fix: use set for mentions comparison

appfolio · Nov 21, 2023 · bf2fc2f · bf2fc2f
1 parent d46a736
commit bf2fc2f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/components/Note/NoteMentions.tsx b/src/components/Note/NoteMentions.tsx
@@ -63,7 +63,7 @@ const NoteMentions: FC<NoteMentionsProps> = ({
 }) => {
   const { deleted, editing, text } = note;
 
-  const mentionStrings = mentionableUsers.map((user) => `@${user.value}`);
+  const mentionStrings = new Set(mentionableUsers.map((user) => `@${user.value}`));
 
   const mentionStyles = () => (
     <style jsx global>
@@ -109,8 +109,8 @@ const NoteMentions: FC<NoteMentionsProps> = ({
       />
       <CardBody>
         <CardText style={{ whiteSpace: 'pre-wrap' }}>
-          {text.split(/(\s+)/).map((word) =>
-            mentionStrings.includes(word) ? (
+          {text?.split(/(\s+)/).map((word) =>
+            mentionStrings.has(word) ? (
               <span className="note__mention-info">
                 {word}
                 {mentionStyles()}