Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Add deprecation message to readme #28

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Add deprecation message to readme #28

merged 1 commit into from
Jul 16, 2024

Conversation

mdalpozzo
Copy link
Contributor

adds deprecation message to readme

@mdalpozzo mdalpozzo requested a review from davidacevedo July 15, 2024 18:31
Copy link
Contributor

@davidacevedo davidacevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment will be similar on the other PR

Readme.md Outdated
@@ -1,5 +1,7 @@
# Appfolio base ESLint config

## ** This is config is now deprecated, please use https://github.com/appfolio/front-end-libs ([package](https://github.com/appfolio/front-end-libs/pkgs/npm/eslint-config-appfolio)) **
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to link to the subdirectory with the eslint config as it's a monorepo

@mdalpozzo mdalpozzo force-pushed the deprecation-message branch from 1548326 to 42e7e73 Compare July 16, 2024 16:14
@mdalpozzo mdalpozzo requested a review from davidacevedo July 16, 2024 16:15
@mdalpozzo mdalpozzo merged commit 3af951e into master Jul 16, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants